feat: support interpreter_path from py3_toolchain #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattem
force-pushed
the
feat/interpreter_path
branch
2 times, most recently
from
ec6ec3d to
9257c72
Compare
py/private/utils.bzl
Outdated
| uses_interpreter_path = True | ||
|
|
||
| if interpreter == None: | ||
| fail("Unable to resolve interpreter to a path or file. Ensure `interpreter` or `interpreter_file` is deifned on the py3_runtime") |
Member
There was a problem hiding this comment.
When would you actually hit this? Also nit on deifned
Member
There was a problem hiding this comment.
Even if py3_toolchain.interpreter_path, is None would you not get:
interpreter = {
path = None,
short_path = None
}
Member
There was a problem hiding this comment.
Oh wait. If py3_toolchain.interpreter is None. Nevermind
alexeagle
approved these changes
May 13, 2022
mattem
force-pushed
the
feat/interpreter_path
branch
from
9257c72 to
d3cbe82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19