Skip to content

fix: remove check on missing interpreter or interpreter_path on the toolchain #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2022
Merged

fix: remove check on missing interpreter or interpreter_path on the toolchain #27

merged 1 commit into from
May 18, 2022

Conversation

@mattem
Copy link
Collaborator

@mattem mattem commented May 18, 2022

@JesseTatasciore was right, this is a pointless check as it's already validated by bazel on the py_runtime rule:

ERROR: /private/var/tmp/_bazel_matt/b28310042610550fd4cf1ffc282c1f7a/external/host_python_autodecting_toolchain/BUILD.bazel:3:11: in py_runtime rule @host_python_autodecting_toolchain//:autodecting_python3_runtime: exactly one of the 'interpreter' or 'interpreter_path' attributes must be specified

@mattem mattem merged commit 8f4a196 into main May 18, 2022
@mattem mattem deleted the fix/pointless_check branch May 18, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexeagle alexeagle alexeagle approved these changes

@JesseTatasciore JesseTatasciore Awaiting requested review from JesseTatasciore

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattem @alexeagle