fix: don't add source files to requirements files from transitive native py_library rules #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ive py_library rules
alexeagle
reviewed
Jun 2, 2022
| elif DefaultInfo in filegroup: | ||
| elif DefaultInfo in filegroup and not PyInfo in filegroup: | ||
| # This is slightly incorrect, but we don't yet have a better way of knowing if the dependency is a filegroup | ||
| # that we should consume a wheel from. |
Member
There was a problem hiding this comment.
file an issue on rules_python, if we think the right fix is to put more Info on these targets?
Collaborator
Author
There was a problem hiding this comment.
Yeah ideally the PyWheelInfo is removed from rules_py and added to rules_python, and the filegroup in the generated BUILD files for PyPi dependencies become the py_wheel rule.
alexeagle
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only take the
DefaultInfowhen there is noPyInfo. This stops us adding the source files from a rules_python / native py_library to the requirements file when installing wheels.This is kinda a workaround that the upstream rules_python doesn't have a provider that can give a reference to the wheel, and we must get it from the
DefaultInfoof a filegroup.