Skip to content

Conversation

@mattem
Copy link
Collaborator

@mattem mattem commented Jun 6, 2022

Don't set the sibling attribute on the venv directory when creating it in the action. This fixes the error

Error in declare_directory: the output directory 'py/tests/external-deps/custom-macro/click_sibling_binary.venv.source' is not under package directory 'py/tests/external-deps/sibling-package' for target '//py/tests/external-deps/sibling-package:click_sibling_binary'

When referencing a source file that is referenced in a rule is referenced outside of that package or its direct ancestors. A way to repro and test this is create a simple macro that references the __main__.py file from where the macro is, rather than where it's called.

@mattem mattem requested a review from alexeagle June 6, 2022 14:56
@mattem mattem merged commit 8360d89 into main Jun 6, 2022
@mattem mattem deleted the fix/no-siblings branch June 6, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants