Skip to content

Conversation

@mattem
Copy link
Collaborator

@mattem mattem commented Jun 8, 2022

Return a PyInfo provider from the py_binary (and, py_test for that matter) rules. This allows them to be plugged into the py*_image rules from rules_docker.

There is a slight caveat here - if the user is using the wheel approach then the PyInfo provider is not sufficient in providing all the required files to put into the container. Will circle back and think about that one.

@mattem mattem requested a review from alexeagle June 8, 2022 20:14
@mattem mattem merged commit 28e8155 into main Jun 8, 2022
@mattem mattem deleted the feat/binary_pyinfo branch June 8, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants