generated from bazel-contrib/rules-template
-
-
Notifications
You must be signed in to change notification settings - Fork 57
fix(py_venv): Carefully resolve executable name to identify runfiles #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thesayyn
approved these changes
Oct 8, 2025
8d080e5 to
6d314ef
Compare
6d314ef to
3b2a533
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Fixes #649.
There are two issues which combine to produce this problem.
Defect 1 --
venv_shimresolves not enough linksThis is a problem because the runfiles implementations all variously rely on inspecting
argv[0](the current executable name) in order to configure the runfiles tree. When entering thepython3interpreter within the venv within the runfiles tree,argv[0]must contain a*.runfiles/parent directory in order to configure properly.Since resolving no links is wrong and resolving all links is also wrong we have to carefully resolve just enough links in the path of the interpreter to identify the
.runfiles/dir.If there's no intermediate symlink state which contains the
.runfilespath segment, then the link as originally created was incorrect and cannot be resolved correctly. If there is such a state, this logic will find it.Defect 2 --
link.pyresolves too many linksChanges are visible to end-users: yes/no
Test plan
On MacOS;
Also hand-tested on Linux to the same effect, which is the source of the manual
current_executable()behavior.