Skip to content

Conversation

@AmnestyAM
Copy link
Contributor

@AmnestyAM AmnestyAM commented Nov 18, 2024

Pull Request

What changed?

adds 3 markdown files for changelogs

Why did it change?

Starts to resolve #27

Still need to add a GitHub Action to populate the Changelogs...

Did you fix any specific issues?

Consistency to changelogs
I would check the HTML comment added in the mark down file is hidden from the front end, if not we could use / try the liquid template format.. or just don't add the link to the menu until we add a new version.

{% comment %} 
{% endcomment %}

CERTIFICATION

By opening this pull request, I do agree to abide by the Code of Conduct and be bound by the terms of the Contribution Guidelines in effect on the date and time of my contribution as proven by the revision information in GitHub.

Signed-off-by: Amnesty AM <37809410+AmnestyAM@users.noreply.github.com>
Signed-off-by: Amnesty AM <37809410+AmnestyAM@users.noreply.github.com>
Signed-off-by: Amnesty AM <37809410+AmnestyAM@users.noreply.github.com>
Signed-off-by: Amnesty AM <37809410+AmnestyAM@users.noreply.github.com>
Signed-off-by: Amnesty AM <37809410+AmnestyAM@users.noreply.github.com>
Signed-off-by: Amnesty AM <37809410+AmnestyAM@users.noreply.github.com>
Signed-off-by: Amnesty AM <37809410+AmnestyAM@users.noreply.github.com>
Signed-off-by: Amnesty AM <37809410+AmnestyAM@users.noreply.github.com>
Signed-off-by: Amnesty AM <37809410+AmnestyAM@users.noreply.github.com>
added changelogs to the menu

Signed-off-by: Amnesty AM <37809410+AmnestyAM@users.noreply.github.com>
@AmnestyAM AmnestyAM requested a review from verlev November 18, 2024 13:27
Copy link
Member

@asirota asirota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds the necessary template CHANGELOGs but we still need GitHub Actions to populate these. So not necessarily resolves but partially resolves #27

@asirota asirota self-assigned this Nov 18, 2024
@asirota asirota added the documentation Improvements or additions to documentation label Nov 18, 2024
@AmnestyAM
Copy link
Contributor Author

For now feel free to add a ticket in this repo with the release candidate link and I can do that manually for now, if you can get someone to automate it that would be amazing, or someone working on the other repos can do a PR on the change log here.

@asirota asirota merged commit c14e894 into aspirepress:main Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Introduce a changelog to all AP modules

2 participants