Update SimpleTypeModelBinder.cs #14492
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-mvc
Contributor
|
Thanks for your PR, @miguelhasse. |
Fix for issue #10191 addressing the specific scenario of flags Enum type.
Author
|
@mkArtakMSFT all unit tests pass, and I've made a change to confine the fix to the specific scenario. The failing integration tests don't seem to be related to my fix. |
Contributor
|
Thanks @miguelhasse. This doesn't look like the right fix. I think we need to start by figuring out what the wire format for this would be, and how it works for and how round tripping would work. I'm going to close this for now. Could we start by discussing this in the issue first? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Addresses #10191