Conversation
natemcmaster
approved these changes
Feb 5, 2019
Member
|
Do you need to do it this way? Would TypeForwardFrom work? Or nah? |
Contributor
Author
|
I thought |
Member
|
Ah I see. |
Member
|
@pranavkm how did you test this? Should we reference the 2.1 package in one of our tests? |
Contributor
Author
|
I added a reference to the Swashbuckle in the MvcSandbox and saw it fail as soon as I referenced
Would help to test it against a real app (something that references the framework, like MusicStore), but it's really unlikely this is a scenario we would regress. |
pranavkm
force-pushed
the
prkrishn/type-forward
branch
from
10ff8fb to
094c531
Compare
davidfowl
approved these changes
Feb 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7220