Skip to content

Make location of PackagePublisher availabe as an MSbuild property #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2017
Merged

Make location of PackagePublisher availabe as an MSbuild property #239

merged 2 commits into from
Apr 21, 2017

Conversation

@natemcmaster
Copy link
Contributor

@natemcmaster natemcmaster commented Apr 21, 2017

@natemcmaster natemcmaster requested review from kichalla and pakrym April 21, 2017 15:55
@natemcmaster natemcmaster mentioned this pull request Apr 21, 2017
Merged
@pakrym
Copy link
Contributor

pakrym commented Apr 21, 2017

LGTM, is this the only thing causing Import warnings?

@natemcmaster
Copy link
Contributor Author

natemcmaster commented Apr 21, 2017

The warning is caused by using <Project Sdk="Microsoft.NET.Sdk"> in the repo.targets file in aspnet/Universe. Microsoft.NET.Sdk was imported to make available the ResolveDependencies task which reasons about project.assets.json and the nuget cache. Adding this property makes all that unnecessary as the package itself makes a property available pointing to the right file location.

https://github.com/aspnet/Universe/pull/503/files#diff-e45ce6afc81adf6a66a1064a7eeb7ca1R1

@natemcmaster natemcmaster mentioned this pull request Apr 21, 2017
Closed
Eilon
Eilon reviewed Apr 21, 2017
View reviewed changes
src/PackagePublisher/PackagePublisher.nuspec Outdated
</metadata>
<files>
<file src="netcoreapp1.0\" target="/" />
<file src="netcoreapp1.0\build\*.targets" target="/build" />
Copy link
Contributor

@Eilon Eilon Apr 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What files end up in netcoreapp1.0\build\*.targets that then end up in the NUPKG for this?

Copy link
Contributor Author

@natemcmaster natemcmaster Apr 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing. Can be removed. Can't remember why I added it even though I wrote this last night

@natemcmaster natemcmaster merged commit b0ca852 into dev Apr 21, 2017
@natemcmaster natemcmaster deleted the namc/where branch April 21, 2017 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pakrym pakrym Awaiting requested review from pakrym

2 more reviewers

@Eilon Eilon Eilon approved these changes

@kichalla kichalla kichalla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-already-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@natemcmaster @pakrym @Eilon @kichalla @dnfclas