elm logger

[sonjakhan]

moved this from the Logging repo (aspnet/Logging#38), removed the Mvc dependency from the sample, and fixed scoping

[Tratcher]

Style: A little too much var.

[sonjakhan]

@davidfowl @loudej @Eilon

[borgdylan]

is elm ready yet? at least is it close to entering the review procedure?

[Eilon]

Need to add [NotNull] in lots of places. Don't need to add it if DI is constructing the object, but in cases where a developer is calling the API we need to add guards.

[sonjakhan]

@borgdylan hopefully soon! it's in the review process

[Eilon]

I think both Guid and LogLevel are structs and so cannot be null. (Hopefully when we eventually implement the NotNull stuff it'll throw under such usage.)

[sonjakhan]

@davidfowl updated

[davidfowl]

context.Request.Query["level"]

[Eilon]

Cool. I think this is for now and anything remaining can be follow-up work items.

[borgdylan]

@sonjakhan I am trying to use elm but I am getting exceptions that the Form could not be read. Why should there be a form if i am accessing /Elm using the browser address bar directly?

[Eilon]

@borgdylan can you log a bug for this? Sonja was an intern and isn't currently working on ELM (though we welcome any future contributions from her! - Hi, @sonjakhan !).