Don't pull entity types from the context when building the Migrations history table#16024
Merged
ajcvickers merged 1 commit intomasterfrom Jun 10, 2019
Merged
Don't pull entity types from the context when building the Migrations history table#16024ajcvickers merged 1 commit intomasterfrom
ajcvickers merged 1 commit intomasterfrom
Conversation
… history table I think this is one of the root causes of the ASP.NET failures in dotnet/aspnetcore#10939 (comment) The issue is that now that we discover DbSets from a context as a convention, re-using the convention-laden ModelBuilder for creating the history table also brings in types from the context. For now, the fix is to remove this convention, but we may want to consider other options for building the history table.
ajcvickers
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Jun 10, 2019
The main change here is to also allow public `HasTables` to be found. This will be removed once we get the new EF merged. The change to the migration makes it align with what we would generate, but I don't think has any functional impact on the tests. See also dotnet/efcore#16024 which (I really hope!)fixes the other failures once it makes it here.
Contributor
Author
|
@AndriySvyryd Would appreciate a quick review, since I want to get this merged so that it can flow to ASP.NET |
Contributor
|
@bricelam @AndriySvyryd please review this with some urgency. It's blocking dependency updates in AspNetCore (nothing since the 5th). |
smitpatel
approved these changes
Jun 10, 2019
Contributor
|
Thanks @smitpatel ❕ |
ghost
deleted the
Contributor
Author
|
Created #16026 to discuss in triage whether there is more to do here. |
ajcvickers
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Jun 10, 2019
The main change here is to also allow public `HasTables` to be found. This will be removed once we get the new EF merged. The change to the migration makes it align with what we would generate, but I don't think has any functional impact on the tests. See also dotnet/efcore#16024 which (I really hope!)fixes the other failures once it makes it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is one of the root causes of the ASP.NET failures in dotnet/aspnetcore#10939 (comment)
The issue is that now that we discover DbSets from a context as a convention, re-using the convention-laden ModelBuilder for creating the history table also brings in types from the context.
For now, the fix is to remove this convention, but we may want to consider other options for building the history table.