Skip to content

Conversation

@onatm
Copy link
Contributor

@onatm onatm commented May 21, 2015

Added instruction to install unzip in order to prevent getting an error message when dnvm use is executed.

  • When I followed the instructions in Getting Started I ran into Cannot find dnx-mono.1.0.0-beta4, do you need to run 'dnvm install 1.0.0-beta4'?. This is solved by installing unzip package.

@dnfclas
Copy link

dnfclas commented May 21, 2015

Hi @onatm, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@Eilon
Copy link
Contributor

Eilon commented May 26, 2015

@glennc ?

@ghost
Copy link

ghost commented May 26, 2015

Does this conflicts with #627? If latter is merged then the instruction to run the command would be rendered redundant.

@onatm
Copy link
Contributor Author

onatm commented May 26, 2015

@jasonwilliams200OK it conflicts with #627. However, you don't need unzip to install libuv as mentioned in #627.

@onatm
Copy link
Contributor Author

onatm commented May 30, 2015

any update?

@glennc
Copy link
Contributor

glennc commented Jun 13, 2015

I'm ok with this one, but perhaps it makes sense to just add a general pre-reqs section to the top of the instructions, what do you think?

@onatm
Copy link
Contributor Author

onatm commented Jun 13, 2015

You are right, general pre-reqs section would be more useful. So, should i create another pr for it?

@ghost
Copy link

ghost commented Jun 13, 2015

@onatm, you can amend the commits of this PR:

# cd into-aspnet-home-directory
notepad .\README
# make changes in the file
# save and close the file
git push -f

@glennc
Copy link
Contributor

glennc commented Jun 15, 2015

I am ok with whatever works best for you, closing this and starting another or amending this one.

@onatm
Copy link
Contributor Author

onatm commented Jun 25, 2015

Does it look OK now?

@glennc
Copy link
Contributor

glennc commented Jun 25, 2015

Yeah, looking good. Can you move curl to the prerequisites section as well? Get it out of the kestrel install step.

On a side note we should make DNVM more flexible so that it can work with wget as well at some point: https://github.com/aspnet/dnvm/blob/dev/src/dnvm.sh#L74

But that is a different issue, for a another time...

@onatm
Copy link
Contributor Author

onatm commented Jun 26, 2015

I added 'Get Curl' to prerequisites section.

I am looking forward to wget download option 👀

@onatm
Copy link
Contributor Author

onatm commented Jul 9, 2015

ping 🔔

@glennc
Copy link
Contributor

glennc commented Sep 23, 2015

Seems good. @danroth27 are you ok with this?

@danroth27
Copy link
Member

Sure :shipit:
At some point we should probably transition all of the Home repo content to just point to http://docs.asp.net.

glennc added a commit that referenced this pull request Sep 25, 2015
Added instruction to install unzip in order to unpack runtime packages
@glennc glennc merged commit a54c950 into dotnet:dev Sep 25, 2015
ryanbrandenburg pushed a commit that referenced this pull request Nov 22, 2018
…master

[automated] Merge branch 'release/2.2' => 'master'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants