-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Added instruction to install unzip in order to unpack runtime packages #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @onatm, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@glennc ? |
|
Does this conflicts with #627? If latter is merged then the instruction to run the command would be rendered redundant. |
|
any update? |
|
I'm ok with this one, but perhaps it makes sense to just add a general pre-reqs section to the top of the instructions, what do you think? |
|
You are right, general pre-reqs section would be more useful. So, should i create another pr for it? |
|
@onatm, you can amend the commits of this PR: # cd into-aspnet-home-directory
notepad .\README
# make changes in the file
# save and close the file
git push -f |
|
I am ok with whatever works best for you, closing this and starting another or amending this one. |
|
Does it look OK now? |
|
Yeah, looking good. Can you move curl to the prerequisites section as well? Get it out of the kestrel install step. On a side note we should make DNVM more flexible so that it can work with wget as well at some point: https://github.com/aspnet/dnvm/blob/dev/src/dnvm.sh#L74 But that is a different issue, for a another time... |
|
I added 'Get Curl' to prerequisites section. I am looking forward to |
|
ping 🔔 |
|
Seems good. @danroth27 are you ok with this? |
|
Sure |
Added instruction to install unzip in order to unpack runtime packages
…master [automated] Merge branch 'release/2.2' => 'master'
Added instruction to install unzip in order to prevent getting an error message when
dnvm useis executed.Cannot find dnx-mono.1.0.0-beta4, do you need to run 'dnvm install 1.0.0-beta4'?. This is solved by installing unzip package.