Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Conversation

@pakrym
Copy link
Contributor

@pakrym pakrym commented Oct 20, 2015

@dnfclas
Copy link

dnfclas commented Oct 20, 2015

Hi @pakrym, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@Tratcher
Copy link
Member

Next you'll need to update Kestrel and WebListener: https://github.com/aspnet/KestrelHttpServer/blob/dev/src/Microsoft.AspNet.Server.Kestrel/Program.cs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidfowl Since this is all static now can we just move it into a WebHostBuilder constructor? That should also fix TestHost.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried, some tests rely on the fact that some of services are not initialized (ThrowsIfNoApplicationEnvironmentIsRegisteredWithTheProvider) and with ApplicationHost always providing static ApplicationEnvironment it fails

@davidfowl
Copy link
Member

Remove the ISP from WebHostBuilder.

@pakrym
Copy link
Contributor Author

pakrym commented Oct 21, 2015

@davidfowl done

@davidfowl
Copy link
Member

Looks good! :shipit:

@rynowak
Copy link
Member

rynowak commented Oct 21, 2015

Is there a reason why we're still waiting on this? MVC is broken

@muratg
Copy link

muratg commented Oct 21, 2015

@rynowak @pakrym should be able to check this in early in the morning.

@davidfowl
Copy link
Member

@rynowak no this was aspnet/dnx@6d13295

@JunTaoLuo
Copy link
Contributor

@pakrym The appveyor failure is due to the renaming of telemetry and should be fixed now. See if you can restart the test. Even if you can't, I think it's safe to checkin since travis is passing now. This is blocking quite a few things.

@pakrym pakrym merged commit 3774b60 into dev Oct 21, 2015
@JunTaoLuo JunTaoLuo deleted the pakrym/services branch October 22, 2015 23:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants