This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Fix pinning of Microsoft.AspNetCore.Server.Testing #841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Could you also update the |
Contributor
Author
|
After merging, I'll do that. I do want @Eilon to see and approve this before I merge just to be sure it gets seen. There's no functional code change here, it's just a change to make sure we can build things properly in this branch moving forwards. |
Contributor
Author
|
Travis failure is because of the OpenSSL issue. We need to do a batch-update of our master travis.yml files to fix this, so I'm going to suggest holding off on that. |
Contributor
|
|
Contributor
Author
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft.AspNetCore.Server.Testing got mis-pinned in the master pinning. The released package was rolled back to 0.1.0 but ended up getting pinned at 1.0.0. This will mess with our ability to rebuild master, so we should remedy this.
NOTE: This is a PR to
master, so it is changing our 1.0.0 release code. The change is not relevant todevbecause the package has been renamed./cc @pranavkm @Eilon