This repository was archived by the owner on Apr 8, 2020. It is now read-only.
On Windows, patch Node's lstat to work around permissions error. Fixes #1101 #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveSandersonMS
force-pushed
the
windows-permissions-workaround
branch
from
112155d to
fd5e3d7
Compare
|
Approved by @Eilon |
|
downgrade npm version to 5.4.2 .worked for me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not great to have to patch Node internals like this, but it's the best we've got in the short term. See #1101 for details of the problem this solves.
This logic was tested on Node versions 0.12.0, 4.6.2, 6.11.0, and 8.1.3 (Windows 10, 64 bit).
Longer term, we need to work with the Node folks to get a proper fix into Node itself and then make this patching logic conditional on older versions of Node.