This repository was archived by the owner on May 21, 2019. It is now read-only.
Disable MSB4011 import warning #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
approved these changes
Apr 21, 2017
pranavkm
reviewed
Apr 21, 2017
| $preflightClpOption='' | ||
| $msbuildClpOption='/clp:Summary' | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Don't check in the zip file
Contributor
|
Can you edit the commit to say this is suppressing the duplicate import warning? |
Contributor
|
We shouldn't import files that have an Sdk attribute. |
Contributor
Contributor
Author
|
@natemcmaster I'll merge it to make it easier to diagnose Universe/Gate builds. We should the right way when we have time or doing changes in the area. |
natemcmaster
pushed a commit
that referenced
this pull request
Apr 21, 2017
This reverts commit 403ef87.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have to many of them and the way to fix is not totally clear. I'll file an issue to investigate and re-enable.
Also https://github.com/Microsoft/msbuild/blob/6851538897f5d7b08024a6d8435bc44be5869e53/src/Build/Evaluation/Evaluator.cs#L2498 indicates that MSBuild guys want to add some special treatment regarding this import and Sdk attributes.