Actually implement the non-lazy version of KeyPerFile.GetValue #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HongGit
reviewed
Jul 5, 2018
| <add key="jsonCustomSetting1" value="Will be replaced by 'SimpleJson' with prefix='customSettings:' and stripPrefix='true'." /> | ||
| <add key="SecretFromFile1" value="This will be replaced by KeyPerFile." /> | ||
| <add key="SECRETFROMFILE2" value="As will this one." /> | ||
| <add key="SubFeature--FeatureSecretA" value="This will be replaced by KeyPerFile if keyDelimiter is set to '--'." /> |
Contributor
There was a problem hiding this comment.
Could you please more specific and point out as File1? This could be confusing and leading to confusion
| ## ## | ||
| ######################################################################################################################## | ||
|
|
||
| Hello there. Sorry to bother you. If this is the first time you are installing this configuration builder into your |
Contributor
There was a problem hiding this comment.
I wouldn't bring up this message like this. If you do want to say something "sorry", I would be more specific on what the sorry is about, like sorry that sorry if this annoys you....
Contributor
There was a problem hiding this comment.
What about adding a "Warning" is more appropriate in this case, what do you think?
HongGit
reviewed
Jul 5, 2018
| <add name="Secrets" userSecretsFile="~/App_Data/secrets.xml" mode="Greedy" type="Microsoft.Configuration.ConfigurationBuilders.UserSecretsConfigBuilder, Microsoft.Configuration.ConfigurationBuilders.UserSecrets, Version=1.0.0.0, Culture=neutral" /> | ||
| <add name="SimpleJson" jsonFile="~/App_Data/settings.json" ignoreMissingFile="true" type="Microsoft.Configuration.ConfigurationBuilders.SimpleJsonConfigBuilder, Microsoft.Configuration.ConfigurationBuilders.Json, Version=1.0.0.0, Culture=neutral" /> | ||
| <add name="KeyPerFile" directoryPath="~/../KeyPerFileSampleRoot" mode="Greedy" keyDelimiter="--" type="Microsoft.Configuration.ConfigurationBuilders.KeyPerFileConfigBuilder, Microsoft.Configuration.ConfigurationBuilders.KeyPerFile, Version=1.0.0.0, Culture=neutral" /> | ||
| <add name="KeyPerFile" directoryPath="~/../KeyPerFileSampleRoot" mode="Strict" keyDelimiter="--" type="Microsoft.Configuration.ConfigurationBuilders.KeyPerFileConfigBuilder, Microsoft.Configuration.ConfigurationBuilders.KeyPerFile, Version=1.0.0.0, Culture=neutral" /> |
Contributor
There was a problem hiding this comment.
For my understanding, this is changed only for your testing purpose, correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops. I missed a few steps when fleshing out a non-greedy KeyPerFile.GetValue().