1.0.4 patch train updates #5788
Conversation
|
@JunTaoLuo I'm just waiting for @pranavkm on #5782. But, why are we calling this 1.0.4? Thought MVC was on the high end with the latest patch branch being |
|
It's the 1.0.4 patch train but the MVC packages will be 1.0.3. The only package that's actually 1.0.4 is MetaPackages. |
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
LGTM with just one question. But I suggest someone else check the specific versions.
| "Microsoft.AspNetCore.Routing.DecisionTree.Sources": { | ||
| "type": "build", | ||
| "version": "1.0.2" | ||
| "version": "1.0.3" |
There was a problem hiding this comment.
Is this the only *.Sources package that's been updated?
There was a problem hiding this comment.
There are a few, you can see all the package version updates in https://github.com/aspnet/Coherence-Patch/pull/40/files#diff-b68e642d223a5f81dc260548f1e0df64.
The *.Sources packages I have seen update are
- Microsoft.AspNetCore.DataProtection.Sources
- Microsoft.AspNetCore.DiagnosticsViewPage.Sources
- Microsoft.AspNetCore.Razor.Test.Sources
- Microsoft.AspNetCore.Routing.DecisionTree.Sources
Any particular concerns regarding sources packages?
There was a problem hiding this comment.
Any particular concerns regarding sources packages?
No. I just noticed this was the only .Sources dependency you updated. Your answer makes sense.
|
All done. @JunTaoLuo that PR is now in the |
|
@JunTaoLuo you need to rebase this branch. No need to re-add the SDK version to global.json for example. |
JunTaoLuo
force-pushed
the
johluo/rel/1.0.3
branch
from
30f8dbb to
c4dabc3
Compare
global.json
Outdated
| "projects": ["src", "test/WebSites", "samples"], | ||
| "sdk": { | ||
| "version": "1.0.0-preview2-003154" | ||
| "version": "1.0.0-preview2-003154" |
There was a problem hiding this comment.
Sigh... inconsistent tabs even within the same file.
Will need to coordinate with @dougbu for #5782