Skip to content
This repository was archived by the owner on Sep 21, 2018. It is now read-only.

Improve Area support in default templates #593

Merged
merged 2 commits into from
Jun 8, 2016
Merged

Improve Area support in default templates #593

merged 2 commits into from
Jun 8, 2016

Conversation

@phenning
Copy link
Contributor

@phenning phenning commented Jun 7, 2016

@phenning
Copy link
Contributor Author

phenning commented Jun 7, 2016

Fixes #591

@joeloff
Copy link
Contributor

joeloff commented Jun 7, 2016

:shipit:

@phenning phenning mentioned this pull request Jun 8, 2016
Closed
@phenning phenning changed the title Add asp-area="" to shared views Improve Area support in default templates Jun 8, 2016
@phenning
Copy link
Contributor Author

phenning commented Jun 8, 2016

@rynowak, added the publish options change to this now as well

rynowak
rynowak reviewed Jun 8, 2016
View reviewed changes
src/BaseTemplates/StarterWeb/project.json
"include": [
"wwwroot",
"Views",
"Areas\**\Views",
Copy link
Member

@rynowak rynowak Jun 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this do the right thing? Just making sure you double checked that this is actually the right include

Copy link
Contributor Author

@phenning phenning Jun 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this works, verified in a sample app

Copy link
Contributor Author

@phenning phenning Jun 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the include should be Areas/**/Views / instead of \

@phenning phenning merged commit 6002146 into dev Jun 8, 2016
@peterblazejewicz peterblazejewicz mentioned this pull request Jun 8, 2016
Closed
peterblazejewicz added a commit to peterblazejewicz/generator-aspnet that referenced this pull request Jun 9, 2016
@peterblazejewicz
Add asp-area tag attribute to links
4e40ccc 
See aspnet/Templates#593
See aspnet/Templates#597

Thanks!
@peterblazejewicz peterblazejewicz mentioned this pull request Jun 9, 2016
Merged
peterblazejewicz added a commit to OmniSharp/generator-aspnet that referenced this pull request Jun 10, 2016
@peterblazejewicz
Add asp-area tag attribute to links (#738)
2721f00 
See aspnet/Templates#593
See aspnet/Templates#597

Thanks!
@phenning phenning deleted the phenning/area branch June 14, 2016 18:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@phenning @joeloff @rynowak @dnfclas