This repository was archived by the owner on May 31, 2019. It is now read-only.
Added 1.0.0-beta4 #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
1.0.0-beta4/Dockerfile
Outdated
Contributor
There was a problem hiding this comment.
comment obsolete, actually doesn't do any installation in this block, also introduces another place to maintain the version number.
Contributor
Author
There was a problem hiding this comment.
I will remove this block
Contributor
There was a problem hiding this comment.
@vlesierse I was just referring to the comment. env vars are still necessary, right?
Contributor
Author
|
Done |
Contributor
|
LGTM. Thanks @vlesierse. closes #50. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a container for beta 4 of ASP.NET 5. Unfortunately the aspnet/Home repo has been changed and gives problems with the CI scripts.