-
Notifications
You must be signed in to change notification settings - Fork 167
Fixed CI tests by excluding 1.0.0-beta3 and earlier #57
Conversation
|
The core clr image is failing at the moment.... |
|
@vlesierse Thanks for the PR. Looks like the that sample is not supposed to run on Linux. |
|
@vlesierse it looks like |
.ci/build-app-image.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor suggestion: maybe another -d ... and else would fail with an error message?
|
I'll make the changes and post an issue in the |
|
@vlesierse yep looks like that's just not implemented in PAL b/c ANSI terminals have no default font color or bg color like windows consoles. However, |
|
@Eilon why is cla required again for him? What's going on here? |
|
We just changed the repos from MS Open Tech to .NET Foundation so there's a different CLA. The new CLA is simpler than the old one and so should only take a few moments to re-sign. Apologies for the extra bit of work! |
|
Ok, signed the CLA on https://cla.dotnetfoundation.org |
|
Thanks @vlesierse ! |
|
LGTM. Thanks. |
Fixed CI tests by excluding 1.0.0-beta3 and earlier
|
BTW I realized ANSI color issue with aspnet/dnx#1768 It's the right call to keep it out of CI for now. |
This PR should fix the CI by excluding the 1.0.0-beta3 and earlier because of the breaking changes.