Update Readme with current instructions #128
Conversation
|
Hi @JosephTremoulet, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
README.md
Outdated
| 1. Clone this repo to the server. | ||
|
|
||
| 1. Navigate to the `./src/Benchmarks` directory under this repo and run the following command to install the latest version of the ASP.NET Core runtime for .NET Core CLR on x64: | ||
| 1. Navigate to the `./src/Benchmarks` directory under this repo and run the following command to restore the latest version of the ASP.NET Core runtime and depedencies for the server application: |
There was a problem hiding this comment.
Typo: "depedencies" -> "dependencies".
There was a problem hiding this comment.
Good catch, thanks. Fixed.
|
@JosephTremoulet: Thanks for submitting this PR! Once the typo is fixed I will merge it. |
JosephTremoulet
force-pushed
the
readme
branch
from
8774d01 to
7f7148e
Compare
README.md
Outdated
| @@ -1,4 +1,4 @@ | |||
| # Benchmarks | |||
| # Benchmarks | |||
There was a problem hiding this comment.
It appears your text editor inserted the UTF-8 Byte Order Mark (BOM), while the original file didn't have a BOM. Can you please remove the BOM?
There was a problem hiding this comment.
Ack, sorry. Fixed.
- Use `dotnet` instead of `dnx` to restore/run - Environment variable to set URLs to bind to is `ASPNETCORE_URLS` - Specify port 5000 rather than 5001 for generating load, since that matches the defaults in the server setup.
JosephTremoulet
force-pushed
the
readme
branch
from
7f7148e to
020241b
Compare
3 participants
dotnetinstead ofdnxto restore/runASPNETCORE_URLSmatches the defaults in the server setup.