Missing dist folder again #1877

[wolfkumpitsch1]

breaking PROD version
dist folder added to ignore in .gitignore

is this going to be the future default?

[mkArtakMSFT]

Thanks for contacting us, @wolfkumpitsch1.
@ryanbrandenburg, what was the motivation for ignoring dist folder?

[Eilon]

We removed it because the idea was that running build (or whatever) will produce it. We don't check in build outputs into the repo, only the "source code."

But I warned this might break something!

Having said that, @wolfkumpitsch1 , can you provide info on what you were doing and how you saw an error?

[Eilon]

This was the PR that removed it: #99

[wolfkumpitsch1]

Hey guys, Working on existing project. Validation component is pulled in via bower. Must have shut down PC over weekend. Component must have been automatically updated on visual studio restart … one minute all’s fine, next minute … well oops Luckily this hasn’t made it into production yet Cheers Wolf From: Eilon Lipton <notifications@github.com> Sent: Tuesday, 16 October 2018 4:05 AM To: aspnet/jquery-validation-unobtrusive <jquery-validation-unobtrusive@noreply.github.com> Cc: Wolf Kumpitsch <wolf.kumpitsch@dbdrv.vic.gov.au>; Mention <mention@noreply.github.com> Subject: Re: [aspnet/jquery-validation-unobtrusive] Missing dist folder again #1877 (#105) We removed it because the idea was that running build (or whatever) will produce it. We don't check in build outputs into the repo, only the "source code." But I warned this might break something! Having said that, @wolfkumpitsch1<https://github.com/wolfkumpitsch1> , can you provide info on what you were doing and how you saw an error? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#105 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AqGld1WsuNjran4feKtkmKYqeUod7Jyrks5ulMA7gaJpZM4XbZ10>.

[ryanbrandenburg]

@wolfkumpitsch1 I think we're asking more like how are you acquiring and using the package. IE, npm, git, nuget etc.

[wolfkumpitsch1]

Ah. Sorry. NPM in VS2017, the setup was created by a 3rd party a few years ago, not my field of strength, sorry. From: Ryan Brandenburg <notifications@github.com> Sent: Tuesday, 16 October 2018 9:50 AM To: aspnet/jquery-validation-unobtrusive <jquery-validation-unobtrusive@noreply.github.com> Cc: Wolf Kumpitsch <wolf.kumpitsch@dbdrv.vic.gov.au>; Mention <mention@noreply.github.com> Subject: Re: [aspnet/jquery-validation-unobtrusive] Missing dist folder again #1877 (#105) @wolfkumpitsch1<https://github.com/wolfkumpitsch1> I think we're asking more like how are you acquiring and using the package. IE, npm, git, nuget etc. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#105 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AqGldzVlHd4TTxDl9MLoMzd1dhEUDmJiks5ulRELgaJpZM4XbZ10>.

[Eilon]

Hi @wolfkumpitsch1 , Bower is unfortunately no longer supported by us and we recommend using an alternative such as NPM to acquire static assets such as this project.

[mkArtakMSFT]

@wolfkumpitsch1, we still don't understand what you're having trouble with. Please provide a repo in GitHub that demonstrates your problem, so we can investigate it.

[danroth27]

After chatting with @javiercn it sounds like Bower in particular expects that the repo contains a dist folder with the production files (i.e. minified), so removing this folder from the repo broke Bower scenarios. That said, you may be able to point to an earlier tagged version that still has the dist folder (ex https://github.com/aspnet/jquery-validation-unobtrusive/tree/v3.2.10).

[danroth27]

@wolfkumpitsch1 Can you switch to using npm directly instead?

[Eilon]

Right, breaking Bower was an explicit decision that was made, so that was deliberate.

[wolfkumpitsch1]

Hey @Artak, all good. Previous comment said my setup is no longer supported … changed over to nuget thanks From: Artak <notifications@github.com> Sent: Thursday, 18 October 2018 3:58 AM To: aspnet/jquery-validation-unobtrusive <jquery-validation-unobtrusive@noreply.github.com> Cc: Wolf Kumpitsch <wolf.kumpitsch@dbdrv.vic.gov.au>; Mention <mention@noreply.github.com> Subject: Re: [aspnet/jquery-validation-unobtrusive] Missing dist folder again #1877 (#105) @wolfkumpitsch1<https://github.com/wolfkumpitsch1>, we still don't understand what you're having trouble with. Please provide a repo in GitHub that demonstrates your problem, so we can investigate it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#105 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AqGld93inQqCtLX1koQitSsuT90WBBh5ks5ul2GzgaJpZM4XbZ10>.

[ryanbrandenburg]

Sounds like you have this under control then. Closing.