Use Nhibernate native asynchronous operations #4765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @shessane for your contribution. Is this done ? If so, we can start reviewing it. |
|
Hello @ismcagdas. |
ryancyq
reviewed
Aug 6, 2019
src/Abp.NHibernate/NHibernate/Repositories/NhRepositoryBaseOfTEntityAndTPrimaryKey.cs
Show resolved
Hide resolved
|
Can we separate refactoring of |
shessane
commented
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here is a small PR to use native asynchronous NHibernate operations, instead of using the synchronous equivalent and return a Task.FromResult.
Unit tests are just duplicated from existing synchronous unit tests.
I've also deleted the SQlite.Interop.dll from Abp.Zero.SampleApp.NHibernateTests.