Skip to content

Entity History EF6 Complex Type property null value #4813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 26, 2019
Merged

Entity History EF6 Complex Type property null value #4813

merged 4 commits into from
Aug 26, 2019

Conversation

@ryancyq
Copy link
Contributor

@ryancyq ryancyq commented Aug 22, 2019

fixes #4812

  • fix incorrect isModified check
  • fix ComplexProperty.HasChanged() by changing
    • DbProperty.GetNewValue() return null if State.Deleted
    • DbProperty.GetOriginalValue() return null if State.Added

@ryancyq ryancyq force-pushed the bugfix/entity-history-ef6 branch from c0a9aae to 6714cde Compare August 22, 2019 01:49
@ryancyq ryancyq force-pushed the bugfix/entity-history-ef6 branch from 6714cde to 6c1f9ce Compare August 22, 2019 01:50
@ryancyq ryancyq added this to the v4.9 milestone Aug 22, 2019
This was referenced Aug 22, 2019
Closed
Closed
@ryancyq ryancyq added the bug label Aug 25, 2019
@ryancyq ryancyq merged commit 9cd3f56 into aspnetboilerplate:dev Aug 26, 2019
@ryancyq ryancyq deleted the bugfix/entity-history-ef6 branch August 26, 2019 00:28
@ryancyq ryancyq mentioned this pull request Oct 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@acjh acjh acjh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

v4.9

Development

Successfully merging this pull request may close these issues.

Entity History EF6 Complex Type Null Value

2 participants

@ryancyq @acjh