Skip to content

fix localization dictionary providers #4824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 29, 2019
Merged

fix localization dictionary providers #4824

merged 6 commits into from
Aug 29, 2019

Conversation

@ryancyq
Copy link
Contributor

@ryancyq ryancyq commented Aug 24, 2019 •
edited
Loading

Follows up #2995

  • [BREAKING]
    • Replace overriable Initialize(string sourceName) with InitializeDictionaries().
    • Reason being that we configure SourceName during Initialize() and SourceName was not and may not be set when overridden.
  • [BREAKING]
    • Move LocalizationDictionaryProviderBase from Abp.Localization.Dictionaries.Xml namespace into Abp.Localization.Dictionaries
  • Move dictionary initialization code into LocalizationDictionaryProviderBase

@ryancyq ryancyq requested a review from hikalkan August 24, 2019 10:12
@ryancyq ryancyq force-pushed the refactor/dictionary-providers branch from 42124e1 to 4a87d0f Compare August 24, 2019 12:23
@ryancyq ryancyq force-pushed the refactor/dictionary-providers branch from 4a87d0f to 9332eb5 Compare August 24, 2019 12:45
@ryancyq ryancyq force-pushed the refactor/dictionary-providers branch from 9332eb5 to 25c085a Compare August 24, 2019 13:14
@ismcagdas ismcagdas added this to the v4.9 milestone Aug 26, 2019
@ismcagdas ismcagdas requested review from ismcagdas and removed request for hikalkan August 29, 2019 08:57
@ismcagdas ismcagdas merged commit 160c04e into aspnetboilerplate:dev Aug 29, 2019
@ryancyq ryancyq deleted the refactor/dictionary-providers branch August 29, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ismcagdas ismcagdas Awaiting requested review from ismcagdas

Assignees

No one assigned

Labels

breaking-change enhancement

Projects

None yet

Milestone

v4.9

Development

Successfully merging this pull request may close these issues.

2 participants

@ryancyq @ismcagdas