Development #122
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,7 +71,15 @@ asmlinkage void InterruptHandler(Registers* regs) { | |
|
|
||
| // Print detailed information | ||
| PrintDetailedFaultInfo(&ctx, regs); | ||
| RegistersDumpT dump = {0}; | ||
| DumpRegisters(&dump); | ||
| // Override with fault context where applicable | ||
| dump.rip = regs->rip; | ||
| dump.cs = regs->cs; | ||
| dump.rflags = regs->rflags; | ||
| dump.rsp = regs->rsp; | ||
| dump.ss = regs->ss; | ||
| PrintRegisters(&dump); | ||
| // Still panic, but now with much more info | ||
|
Comment on lines
+74
to
83
There was a problem hiding this comment. 💡 Verification agent 🧩 Analysis chainDouble-fault safety and panic CLI ordering — please verify. Printing on DF can triple-fault unless ISR #8 uses an IST stack; also ensure PanicFromInterrupt disables interrupts as its first instruction. 🏁 Script executed: #!/bin/bash
# 1) Verify DF (vector 8) uses IST in IDT setup / ASM stubs
rg -n -C3 -i 'double\s*fault|isr8|vector\s*8|ist' arch/x86_64
# 2) Confirm PanicFromInterrupt (and other panic entry points) execute cli first
rg -n -C3 'PanicFromInterrupt\s*\(|KernelPanicHandler\s*\(|Panic\w*\(' kernel | sed -n '1,200p'
rg -n 'asm\s+volatile\("cli"\)' kernelLength of output: 27567 Ensure double-fault uses an IST stack; panic CLI ordering is correct
|
||
| PanicFromInterrupt(ctx.fault_reason, regs); | ||
| break; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| #include "POST.h" | ||
| #include "Console.h" | ||
| #include "KernelHeap.h" | ||
| #include "PMem.h" | ||
| #include "Panic.h" | ||
| #include "Serial.h" | ||
| #include "VMem.h" | ||
| #include "stdbool.h" | ||
|
|
||
| #define N 512 | ||
| void * ptrs[N] = {0}; | ||
|
|
||
| uint64_t seed = 0x12345; | ||
| uint64_t rnd() { seed = seed * 6364136223846793005ULL + 1; return seed; } | ||
|
|
||
| bool SerialTest() { | ||
| for (int i = 0; i < 128; i++) { | ||
| if (SerialWrite(".") < 0) return false; | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| bool MemoryTest() { | ||
| for (int i = 1; i < 1000; i++) { | ||
| size_t sz = (i % 7 == 0) ? 4096 : (i % 100 + 1); | ||
| void *ptr = KernelMemoryAlloc(sz); | ||
| if (!ptr) return false; | ||
| KernelFree(ptr); | ||
| } | ||
| // | ||
| for (int i = 0; i < N; i++) ptrs[i] = KernelMemoryAlloc(128); | ||
|
|
||
| // free every other block | ||
| for (int i = 0; i < N; i += 2) KernelFree(ptrs[i]); | ||
|
|
||
| // re-allocate in different sizes | ||
| for (int i = 0; i < N/2; i++) { | ||
| ptrs[i] = KernelMemoryAlloc((i % 2) ? 64 : 256); | ||
| } | ||
|
|
||
| for (int iter = 0; iter < 100000; iter++) { | ||
| int idx = rnd() % N; | ||
| if (ptrs[idx]) { | ||
| KernelFree(ptrs[idx]); | ||
| ptrs[idx] = NULL; | ||
| } else { | ||
| size_t sz = (rnd() % 8192) + 1; // 1–8K | ||
| ptrs[idx] = KernelMemoryAlloc(sz); | ||
| if (!ptrs[idx]) PANIC("OOM during fuzz"); | ||
| } | ||
| } | ||
|
|
||
| for (uintptr_t addr = 0x400000; addr < 0x800000; addr += 0x1000) { | ||
| void* frame = AllocPage(); | ||
| VMemMap(addr, (uint64_t)frame, PAGE_PRESENT | PAGE_WRITABLE); | ||
| VMemUnmap(addr, PAGE_SIZE); | ||
| FreePage(frame); | ||
| } | ||
|
Comment on lines
+53
to
+58
There was a problem hiding this comment. 🛠️ Refactor suggestion Check map/unmap return codes and handle page alloc failure. Ignoring errors risks leaking mapped pages or freeing still-mapped frames. - for (uintptr_t addr = 0x400000; addr < 0x800000; addr += 0x1000) {
- void* frame = AllocPage();
- VMemMap(addr, (uint64_t)frame, PAGE_PRESENT | PAGE_WRITABLE);
- VMemUnmap(addr, PAGE_SIZE);
- FreePage(frame);
- }
+ for (uintptr_t addr = 0x400000; addr < 0x800000; addr += 0x1000) {
+ void* frame = AllocPage();
+ if (!frame) return false;
+ int rc = VMemMap(addr, (uint64_t)frame, PAGE_PRESENT | PAGE_WRITABLE);
+ if (rc != VMEM_SUCCESS) { FreePage(frame); return false; }
+ rc = VMemUnmap(addr, PAGE_SIZE);
+ if (rc != VMEM_SUCCESS) { FreePage(frame); return false; }
+ FreePage(frame);
+ }
|
||
|
|
||
| for (int i = 0; i < 1000; i++) { | ||
| size_t sz = (i % 500) + 1; | ||
| uint8_t *p = (uint8_t*)KernelMemoryAlloc(sz); | ||
| for (size_t j = 0; j < sz; j++) p[j] = (uint8_t)(i ^ j); | ||
| for (size_t j = 0; j < sz; j++) | ||
| if (p[j] != (uint8_t)(i ^ j)) PANIC("Memory corruption!"); | ||
| KernelFree(p); | ||
| } | ||
|
|
||
| return true; | ||
| } | ||
|
Comment on lines
+69
to
+70
There was a problem hiding this comment. 🛠️ Refactor suggestion Free any remaining fuzz allocations to avoid a boot-time leak. POST runs once but leaking kernel heap here is avoidable. - return true;
+ // Cleanup any remaining allocations from fuzzing
+ for (int i = 0; i < N; i++) {
+ if (ptrs[i]) { KernelFree(ptrs[i]); ptrs[i] = NULL; }
+ }
+ return true;
🤖 Prompt for AI Agents |
||
|
|
||
| void POSTHandler(const char * args) { | ||
| (void)args; | ||
| if (!SerialTest()) PrintKernelWarning("Serial test failed\n"); | ||
| if (!MemoryTest()) PrintKernelWarning("Memory test failed\n"); | ||
| PrintKernelSuccess("POST test passed\n"); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| #ifndef VOIDFRAME_POST_H | ||
| #define VOIDFRAME_POST_H | ||
|
|
||
| void POSTHandler(const char * args); | ||
|
|
||
| #endif // VOIDFRAME_POST_H |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.