Development

[assembler-0]

Fixes quick start command for cmake, removed XMake

Summary by CodeRabbit

• Documentation

  • Removed XMake prerequisites and usage from README and Development guide.
  • Updated CMake guidance for VF_SCHEDULER with clearer example and inline comment.

• Chores

  • Dropped XMake build support by removing its build configuration and tasks.

• Refactor

  • Changed default scheduler to EEVDF (was MLFQ) via build configuration, affecting default runtime behavior for new builds.

[coderabbitai]

Walkthrough

Removes XMake support across the repository and documentation. Updates CMake guidance and changes the default VF_SCHEDULER cache value from MLFQ to EEVDF. Cleans up README and DEVELOPMENT docs to drop XMake instructions. Deletes the xmake.lua build configuration file.

Changes

Cohort / File(s)	Summary
Docs: remove XMake references README.md, docs/DEVELOPMENT.md	Eliminated XMake prerequisites and usage sections; adjusted CMake snippet formatting; retained non-XMake build instructions.
CMake cache: scheduler default cmake/cache.cmake	Changed VF_SCHEDULER default from "MLFQ" to "EEVDF"; description and property settings unchanged.
XMake build removal xmake.lua	Fully removed the XMake project and targets, flags, defines, tasks, and file lists.

Sequence Diagram(s)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• Development #141 — Directly conflicts on XMake integration: that PR adds xmake.lua and docs while this one removes them.
• Development #143 — Introduces EEVDF scheduler and VF_SCHEDULER option; this PR switches the default to EEVDF.

Poem

I hop through builds, ears up high,
XMake gone—so long, goodbye.
CMake whispers: “EEVDF by default,”
Schedulers shuffle, plans exalt.
Docs are tidied, paths made clear—
Thump-thump! a rabbit engineer.
Onward we bound, with lighter gear.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title Check	❓ Inconclusive	The pull request title “Development” is too vague and does not convey the primary changes such as removing XMake support or updating the default scheduler; a title should clearly reflect the main change for easy history scanning.	Please choose a more descriptive title that summarizes the key change, for example “Remove XMake build configuration and update default VF_SCHEDULER to EEVDF,” so reviewers can quickly understand the PR’s purpose.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch Development

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34422f7 and 8c01af5.

📒 Files selected for processing (4)

• README.md (1 hunks)
• cmake/cache.cmake (1 hunks)
• docs/DEVELOPMENT.md (3 hunks)
• xmake.lua (0 hunks)

💤 Files with no reviewable changes (1)

• xmake.lua

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-08-12T03:19:52.873Z

Learnt from: assembler-0
PR: assembler-0/VoidFrame#73
File: kernel/elf/ELFloader.c:0-0
Timestamp: 2025-08-12T03:19:52.873Z
Learning: VoidFrame kernel now has complete UEFI boot support with hybrid BIOS/UEFI ISO creation capability. The existing VBE framebuffer implementation requires no changes as it uses Multiboot2 framebuffer tags and direct memory-mapped access, making it inherently UEFI-compatible. Build process: ninja + ./scripts/build_hybrid_iso.sh creates dual-platform bootable ISO.

Applied to files:

• README.md

🔇 Additional comments (3)

docs/DEVELOPMENT.md (3)

12-12: LGTM! XMake removed from build systems.

The removal of XMake from the prerequisites aligns with the PR objective and is consistently applied throughout the documentation.

---

32-32: LGTM! XMake removed from Arch Linux dependencies.

The package installation command correctly removes the xmake dependency.

---

67-67: LGTM! XMake removed from macOS dependencies.

The Homebrew installation command correctly removes the xmake dependency.

[coderabbitai]

🛠️ Refactor suggestion | 🟠 Major

🧩 Analysis chain

Default scheduler changed to EEVDF.

The change updates the default from MLFQ to EEVDF. Ensure that all documentation and quickstart guides reflect this new default accurately.

Run the following script to verify documentation consistency:

---

🏁 Script executed:

#!/bin/bash
# Description: Check if all documentation mentions the correct default scheduler

# Search for mentions of VF_SCHEDULER or scheduler defaults in documentation
rg -n -C2 'VF_SCHEDULER|default.*scheduler|scheduler.*default' README.md docs/

Length of output: 270

---

Update default scheduler in documentation

In README.md (line 64), change the comment from “# Optional, default: MLFQ” to “# Optional, default: EEVDF”.

🤖 Prompt for AI Agents

In cmake/cache.cmake around line 4 and README.md at line 64, the default
scheduler is set to "EEVDF" but the README comment still says "# Optional,
default: MLFQ"; update the README.md line 64 comment to read "# Optional,
default: EEVDF" so the documented default matches cmake/cache.cmake, and scan
for any other occurrences of the old default to keep documentation consistent.