Development

[assembler-0]

Summary by CodeRabbit

• New Features

  • Introduced a comprehensive configuration for code quality and style checks.
  • Enhanced system stability by attempting a forced reboot during kernel panic situations.

• Bug Fixes

  • Improved error reporting when the process termination queue is full, now triggering a system panic with a clear message.

• Style

  • Updated log message prefixes from "[KERNEL]" to "[SYSTEM]" for consistency and clarity.

• Chores

  • Adjusted QEMU launch settings to prevent automatic reboot or shutdown after system exit.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

A new .clang-tidy configuration file was introduced to enforce specific code quality checks. Kernel panic handling was refactored to attempt a forced reboot before halting, with updated logging prefixes from "[KERNEL]" to "[SYSTEM]". QEMU run options were adjusted to prevent automatic reboot and shutdown after guest exit.

Changes

File(s)	Change Summary
.clang-tidy	Added a detailed Clang-Tidy configuration enabling and disabling selected static analysis checks.
Kernel/Core/Panic.c	Refactored panic handling: added ForceReboot(), updated KernelPanicHandler() to attempt reboot, revised panic message formatting.
Kernel/Process/Process.c	Updated logging prefixes to "[SYSTEM]", improved error handling in termination queue overflow.
meson.build	Added -no-reboot and -no-shutdown to QEMU run target command.

Sequence Diagram(s)

sequenceDiagram
    participant System
    participant Kernel
    participant Hardware

    System->>Kernel: Panic() or PanicWithCode()
    Kernel->>Kernel: Print "[SYSTEM]" panic message
    Kernel->>Kernel: KernelPanicHandler()
    Kernel->>Hardware: ForceReboot()
    alt Reboot Succeeds
        Hardware-->>System: System restarts
    else Reboot Fails
        Kernel->>Kernel: Halt CPU (infinite loop)
    end

Loading

Possibly related PRs

• Cracked #17: Comments out screen clearing in panic functions, related to panic handling changes.
• Development #7: Introduces initial panic functions and declarations, directly related to the refactoring and extension of panic logic in this PR.

Poem

A clangy new file, with tidy in tow,
Panic now tries a reboot, before saying "no."
SYSTEM logs echo, where KERNEL once lay,
QEMU stands patient, no shutdown today.
A rabbit approves, with a hop and a cheer—
Code grows more robust, year after year!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22fc6bb and 3d0ec5e.

📒 Files selected for processing (4)

• .clang-tidy (1 hunks)
• Kernel/Core/Panic.c (1 hunks)
• Kernel/Process/Process.c (5 hunks)
• meson.build (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.