Fix Terminating problem

[assembler-0]

Summary by CodeRabbit

• New Features

  • Introduced process immunity, preventing certain system processes from being terminated by non-system processes.
  • Added a command to display a formatted list of all processes, showing their PID, state, privilege level, and immunity status.

• Improvements

  • Enhanced process termination security, with stricter checks and immediate action against unauthorized termination attempts.
  • Improved error messages and process state reporting for better clarity.

• Bug Fixes

  • Corrected process listing to include the idle process.

• Other

  • Restored detailed scheduler state reporting for debugging purposes.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

A process immunity flag was introduced to prevent certain processes from being terminated by non-system processes. The TerminateProcess function now includes privilege and immunity checks, terminating unauthorized callers. The idle, SKIS, and tracer processes are marked immune. New process listing and restored scheduler dump functions were added, with minor code cleanups throughout.

Changes

File(s)	Change Summary
Kernel/Process/Process.c	Added process immunity flag, enhanced TerminateProcess with security/immunity checks, marked system processes as immune, added ListProcesses, restored DumpSchedulerState, improved formatting and error messages, code cleanup.
Kernel/Process/Process.h	Removed SystemService declaration, added ListProcesses declaration.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Kernel
    participant TargetProcess

    Caller->>Kernel: TerminateProcess(target_pid, reason, exit_code)
    alt Caller is not system and reason != TERM_SECURITY
        Kernel->>Caller: Terminate caller (unauthorized)
    else alt TargetProcess is immune
        Kernel->>Caller: Terminate caller (attempted immune termination)
    else
        Kernel->>TargetProcess: Mark as dying, add to termination queue, set to zombie
        alt Caller == TargetProcess
            Caller->>Caller: Halt execution indefinitely
        end
    end

Loading

Possibly related PRs

• Development #31: Extends the deferred process termination mechanism by introducing process immunity, enhanced security checks, and additional process management features, directly modifying the same code areas.

Poem

In the kernel’s warren, some bunnies now wear shields,
Immune to paws that pry in forbidden fields.
Unauthorized hoppers, beware what you try—
For if you poke the chosen, you’ll be first to say goodbye!
With process lists and scheduler dumps anew,
The system’s garden grows stronger too.
🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5131a43 and 8b8d05a.

📒 Files selected for processing (2)

• Kernel/Process/Process.c (7 hunks)
• Kernel/Process/Process.h (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.