VMem, sched, race condition #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughThis update refactors core kernel components, focusing on virtual memory management, process scheduling, and panic handling. It introduces stricter address validation, corrects spinlock usage, and enhances error handling in memory operations. The scheduler logic is revised for accurate preemption and process state management. Boolean type definitions are standardized, and CPU halting is enforced on kernel panics. Changes
Sequence Diagram(s)sequenceDiagram
participant Timer as Timer Interrupt
participant Scheduler as FastSchedule
participant Proc as Process
participant Queue as Scheduler Queue
Timer->>Scheduler: Invoke FastSchedule(regs)
Scheduler->>Proc: Check current process state
alt Process dying/zombie/terminated
Scheduler-->>Scheduler: Skip context save, do not re-queue
else Healthy process
Scheduler->>Proc: Save CPU context
Scheduler->>Proc: Decrement quantum
alt Quantum expired or higher-priority process exists
Scheduler->>Queue: Demote priority, mark ready, re-queue
Scheduler->>Queue: Select next process
else
Scheduler-->>Proc: Continue running
end
end
Scheduler->>Proc: Switch to next process (if any)
Scheduler->>Scheduler: Update current_running/current_process
sequenceDiagram
participant Kernel as Kernel
participant Panic as Panic Handler
participant CPU as CPU
Kernel->>Panic: Panic or PanicWithCode invoked
Panic->>Panic: Print error, call handler/reboot
Panic->>CPU: Enter infinite hlt loop
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Bug Fixes
New Features
bool,true, andfalsemacros.Improvements