You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change the static variable TESTS had to be declared in the root of the crate in which the #[libtest2::test] macros were used. This was automatically inserted by the #[libtest2::main] macro, but if the user did not include this an error would be shown.
A consequence of this is that the #[libtest2::test] macro could not be used on its own to collect tests, unless the user accessed the hidden, private API exposed in the _private module.
The obvious downside of this change is that the user will no longer receive an error message if they use the #[libtest2::test] macro without #[libtest2::main], and thus no tests will be run. The compiler will, however, still complain if the user is missing a main function.
Note: This does not have an open issue. I figured the conversation around whether or not this is a good change was better made with some code to look at.
Prior to this change the static variable `TESTS` had to be declared in
the root of the crate in which the `#[libtest2::test]` macros were used.
This was automatically inserted by the `#[libtest2::main]` macro, but
if the user did not include this an error would be shown.
A consequence of this is that the `#[libtest2::test]` macro could not be
used on its own to collect tests, unless the user accessed the hidden,
private API exposed in the `_private` module.
The obvious downside of this change is that the user will no longer
receive an error message if they use the `#[libtest2::test]` macro
without `#[libtest2::main]`, and thus no tests will be run. The compiler
will, however, still complain if the user is missing a `main` function.
This, unfortunately, was an intentional choice that I forgot to document in #135 which has now been rectified. I need to transfer that information over into DESIGN.md.
Anything we do with ctor or linkme right now is a polyfill for eventually having that has a feature built-in to the language. Unfortunately, the discussion around the MVP is excluding cross-crate support, so I started without using cross-crate support to not have a reduction in capabilities when we can switch. This also lets us test it out to see how bad it is in practice. Granted, this means we aren't testing what cross-crate would be like and its pros and cons. See rust-lang/testing-devex-team#3.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change the static variable
TESTShad to be declared in the root of the crate in which the#[libtest2::test]macros were used. This was automatically inserted by the#[libtest2::main]macro, but if the user did not include this an error would be shown.A consequence of this is that the
#[libtest2::test]macro could not be used on its own to collect tests, unless the user accessed the hidden, private API exposed in the_privatemodule.The obvious downside of this change is that the user will no longer receive an error message if they use the
#[libtest2::test]macro without#[libtest2::main], and thus no tests will be run. The compiler will, however, still complain if the user is missing amainfunction.Note: This does not have an open issue. I figured the conversation around whether or not this is a good change was better made with some code to look at.