test(test2): Add UI tests for macro error output #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19365796251Details
💛 - Coveralls |
Contributor
Author
|
I think these tests also show how there's definitely some room for improvements in the error messages |
epage
reviewed
Nov 13, 2025
Collaborator
|
Some more cases. Feel free to add or I'll do it in a follow up
|
Contributor
Author
|
I can add those 👍 |
The tests use the `trybuild` crate to check that compilation fails for the incorrect macro use. The test will also fail if the error output changes. These were added directly to the `tests` directory (as opposed to being part of the `testsuite` subdirectory) because the automatic check and overwrite functionality provided by the `trybuild` crate seemed to not work properly when placed there.
skogseth
force-pushed
the
macro-tests
branch
from
3c49f6b to
e97ed34
Compare
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests use the
trybuildcrate to check that compilation fails for the incorrect macro use. The test will also fail if the error output changes.These were added directly to the
testsdirectory (as opposed to being part of thetestsuitesubdirectory) because the automatic check and overwrite functionality provided by thetrybuildcrate seemed to not work properly when placed there.Fixes #157