Skip to content

fix(snap): Clarify naming #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
May 15, 2024
Merged

fix(snap): Clarify naming #310

merged 32 commits into from
May 15, 2024

Conversation

epage
Copy link
Contributor

@epage epage commented May 15, 2024

Pulled from #288, #285, #294, #298, #297, #300, #282

epage added 30 commits May 15, 2024 12:46
@epage
fix(data): Deprecated Data::normalize
9ed0d97
@epage
refactor: Transition from Data::normalize
1cbf588 
Cherry pick of 203add4 (assert-rs#288)
@epage
fix(filter): Move from data to filter
4990ecf 
Cherry-pick fe2fb1e (assert-rs#288)
Cherry-pick 79e3167 (assert-rs#285)
@epage
fix(filter): Rename Normalize::normalize to Normalize::filter
97abb23
@epage
fix(filter): Rename Normalize to Filter
e725688 
Cherry pick 94cb553 (assert-rs#288)
@epage
refactor: Transition from Normalize to Filter
15dd59a
@epage
refactor(assert): Allow multiple mods
e01f907
@epage
fix(assert): Expose mod
2ec281a 
Cherry pick 125d7c4 (assert-rs#294)
@epage
fix(assert): Move Actions into assert mod
5c96a90 
Cherry pick 125d7c4ba3754dab55f1ecfc030184b56868cc710 (assert-rs#294)
@epage
refactor: Transition to assert::DEFAULT_ACTION_ENV
bad9df7
@epage
refactor(assert): Move assert Result into error mod
e484280
@epage
refactor(snap): Use crate::Result
ca0fa17
@epage
fix: Move Error/Result under Assert
8b432b6 
Cherry pick of 125d7c4 (assert-rs#294)
@epage
refactor: Transition to assert::Error
b0553d4
@epage
fix(dir): Rename path feature to dir
61a751f 
Cherry pick 5fc67de (assert-rs#298)
@epage
refactor: Transition to 'dir' feature
949a518
@epage
fix(dir): Move path mod to dir
047e440 
Cherry pick c0a5686 (assert-rs#297)
@epage
refactor: Transition from path to dir mod
0ece894
@epage
refactor(path): Split up mod
23ad14d 
Cherry pick ef2b41e (assert-rs#297)
@epage
fix(snap): Move path root macros to utils
e811421 
Cherry pick 877c0b1 (assert-rs#297)
@epage
refactor(dir): Rename fixture mod to root
b316c3c 
Cherry pick 23c5326 (assert-rs#300)
@epage
fix(dir): Rename PathFixture to DirRoot
31ab285 
Cherry pick 2da9e27 (assert-rs#300)
@epage
fix(filter): Move in normalize_lines/paths
c3a4115 
Cherry pick b52ab61 (assert-rs#282)
@epage
fix: Deprecate normalize_text
b2b1b30
@epage
refactor: Transition off utils::normalize_lines/paths
0706218
@epage
docs(filter): Clarify normalize_paths
6d0a5e0 
Cherry pick 334342e (assert-rs#285)
@epage
fix(filter): Move Substitutions in
b1fe6c4
@epage
refactor(filters): Rename substitution key with placeholder
7416b5a 
Cherry pick 9a76a8b (assert-rs#285)
@epage
refactor(filter): Rename substitutions mod to redactions
954f654
@epage
fix(filter): Rename Subsitutions to Redactions
38bc921 
Inspired by `insta`

Cherry pick 1426fdf (assert-rs#285)
@coveralls
Copy link

coveralls commented May 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9103133107

Details

  • 177 of 360 (49.17%) changed or added relevant lines in 16 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 50.987%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/snapbox/src/data/source.rs 0 1 0.0%
crates/snapbox/src/harness.rs 0 1 0.0%
crates/trycmd/src/schema.rs 9 10 90.0%
crates/snapbox/src/data/normalize.rs 0 2 0.0%
crates/snapbox/src/path.rs 0 3 0.0%
crates/snapbox/src/assert/mod.rs 4 8 50.0%
crates/snapbox/src/data/mod.rs 2 6 33.33%
crates/snapbox/src/filter/redactions.rs 12 16 75.0%
crates/snapbox/src/lib.rs 0 4 0.0%
crates/trycmd/src/runner.rs 6 12 50.0%
Files with Coverage Reduction New Missed Lines %
crates/snapbox/src/data/mod.rs 1 52.56%
crates/snapbox/src/path.rs 1 0.0%
crates/snapbox/src/data/normalize.rs 2 0.0%
Totals Coverage Status
Change from base Build 9100311985: -0.03%
Covered Lines: 1291
Relevant Lines: 2532
💛 - Coveralls

@epage epage enabled auto-merge May 15, 2024 21:50
@epage epage merged commit 291c874 into assert-rs:main May 15, 2024
@epage epage deleted the renames branch May 15, 2024 21:53
@epage epage mentioned this pull request May 16, 2024
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@epage @coveralls