Skip to content

I think BigInteger is also a number and BigInteger("1") is equal to "1". #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2015
Merged

I think BigInteger is also a number and BigInteger("1") is equal to "1". #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7796718
I think BigInteger is also a number and BigInteger("1") is equal to "1".
timo-rohwedder Nov 12, 2015
4bf194a
source format
timo-rohwedder Nov 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/org/assertj/db/type/Value.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
package org.assertj.db.type;

import java.math.BigDecimal;
import java.math.BigInteger;
import java.sql.Date;
import java.sql.Time;
import java.sql.Timestamp;
Expand Down Expand Up @@ -82,7 +83,8 @@ static ValueType getType(Object object) {
|| object instanceof Long
|| object instanceof Float
|| object instanceof Double
|| object instanceof BigDecimal) {
|| object instanceof BigDecimal
|| object instanceof BigInteger) {

return ValueType.NUMBER;
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/assertj/db/util/Values_AreEqual_Object_And_Object_Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ public void test_are_equal_for_double_and_string() throws Exception {
*/
@Test
public void test_are_equal_for_biginteger_and_string() throws Exception {
assertThat(Values.areEqual(getValue(null, new BigInteger("1")), (Object) "1")).isFalse();
assertThat(Values.areEqual(getValue(null, new BigInteger("1")), (Object) "1")).isTrue();
assertThat(Values.areEqual(getValue(null, new BigInteger("2")), (Object) "1")).isFalse();
}

Expand Down