Collapse consecutive assertThat statements using the same object #65
+85
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.testing.assertj.CollapseConsecutiveAssertThatStatements?organizationId=NWEyODY5YjUtYjZkYS00MDY1LTg5M2YtNjI4YTBlZmE5NzQ3 Co-authored-by: Moderne <team@moderne.io>
Member
|
It's very much appreciated 🙂 Thanks for it! Eventually, we'll move this repo into the main multimodule (assertj/assertj#2424), but any improvement is always welcome! |
timtebeek
deleted the
refactor/collapse-consecutive-assert-that-statements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi! Hope this is appreciated; was reading the examples and saw that these aren't using chained assertions as much as they could. Figured it'd be helpful to set the example that that is very much a thing you can do with AssertJ, to get away from repeated lines starting with the same
assertThat(actual).If this is not appreciated also let me know; there's a few other improvements I'd held off on to make this easier to review.