Fix containsExactly not working properly with maps not using equals to compare keys
#2500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the existing tests are not providing the needed coverage, especially for unmodifiable implementations. The best would be having two parameterized tests like in and |
* Catch the `UnsupportedOperationException` in `createEmptyMap` if the clone cannot be clear * Make `clone` method throw an `UnsupportedOperationException` if the map is immutable * Catch the `UnsupportedOperationException` in `compareActualMapAndExpectedEntries` if the clone method throws it
sarajuhosova
force-pushed
the
2165-containsexactly-maps-not-using-equals
branch
from
74001de to
9824e79
Compare
…s thrown by persistant maps
|
I added the tests and we fixed some errors that came from them 🙂 |
# Conflicts: # src/main/java/org/assertj/core/internal/Maps.java
|
closing as it is addressed by #2623 which keeps @wouterpolet as the author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List:
containsExactlydoes not work properly with maps not using equals to compare keys #2165Let me know if there is anything I missed.
I created tests that run on all case insensitive maps, but didn't add ones for normal ones. I wasn't sure if the existing test suite is already sufficient. I can still add that of course.