Fixing screenshots on IE #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glibas
reviewed
Sep 20, 2016
Member
glibas
left a comment
glibas
left a comment
There was a problem hiding this comment.
Hi @unleashurgeek,
Thank you for your contribution. Could you please update the PR according to comments.
| @@ -1 +1 @@ | |||
| return window.scrollY; No newline at end of file | |||
| Math.max(document.documentElement.scrollTop, document.body.scrollTop); No newline at end of file | |||
Member
There was a problem hiding this comment.
return statement is missing in get-current-scrollY.js
Contributor
Author
|
Oops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when running this library with IE, the tests will crash with a null pointer exception. This is due to window.scrollX and window.scrollY not being supported in IE.
This PR fixes the problem.