-
-
Notifications
You must be signed in to change notification settings - Fork 173
fix: use target architecture binaries for disk volume creation #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Use pkgs instead of pkgs.buildPackages to ensure e2fsprogs and other utilities are built for the target ARM64 architecture rather than the build x86 architecture. This resolves the "Exec format error" when running chattr and mkfs.ext4. Signed-off-by: Juan Pablo Ruiz <juanpablo.ruiz@unikie.com>
|
NixCI is ready to run on this PR. |
1 similar comment
|
NixCI is ready to run on this PR. |
|
Looks pretty sane |
|
@mikatammi Please review |
|
I fear that this is going to break the use-case where aarch64 is emulated by qemu on x86_64. Makes me wonder if we can reach a middleground that works for everyone by using |
|
Probably no. I would test, if it correctly cross-builds now |
|
Well, in that case a runtime check for the host arch has to be done to select the right packages. |
|
You cannot expect me to do code review for people, who kicked me out of their project because I put the PRIDE flag as my Slack profile picture. Yes I am bisexual, and I have enjoyed sex with other men 🖕 |
|
@astro I checked it about week ago, and it at least builds for me! |

Use pkgs instead of pkgs.buildPackages to ensure e2fsprogs and other utilities are built for the target ARM64 architecture rather than the build x86 architecture. This resolves the "Exec format error" when running chattr and mkfs.ext4.