Skip to content

Conversation

@smcguire-cmu
Copy link
Contributor

Fixes #548

@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.45%. Comparing base (74a443b) to head (500e26c).
Report is 251 commits behind head on main.

Files with missing lines Patch % Lines
src/lsdb/catalog/catalog.py 90.90% 1 Missing ⚠️
...b/core/crossmatch/abstract_crossmatch_algorithm.py 95.23% 1 Missing ⚠️
src/lsdb/dask/crossmatch_catalog_data.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
- Coverage   97.50%   97.45%   -0.05%     
==========================================
  Files          44       44              
  Lines        1960     2007      +47     
==========================================
+ Hits         1911     1956      +45     
- Misses         49       51       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Apr 21, 2025

Before [5b54f46] After [90b5d91] Ratio Benchmark (Parameter)
11.9±0.3ms 12.2±0.2ms 1.02 benchmarks.time_box_filter_on_partition
74.2±1ms 75.5±1ms 1.02 benchmarks.time_kdtree_crossmatch
24.1±0.6ms 24.4±0.6ms 1.01 benchmarks.time_polygon_search
6.60±0.01s 6.61±0.04s 1 benchmarks.time_create_large_catalog
983±10ms 984±10ms 1 benchmarks.time_create_midsize_catalog

Click here to view all benchmarks.

Copy link
Collaborator

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor comments

@smcguire-cmu smcguire-cmu force-pushed the sean/nested-crossmatch branch from fd8a40a to 4b6924d Compare April 23, 2025 16:23
@smcguire-cmu smcguire-cmu merged commit c96fa7d into main Apr 25, 2025
10 of 12 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/nested-crossmatch branch April 25, 2025 19:02
@delucchi-cmu delucchi-cmu mentioned this pull request May 13, 2025
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Catalog.crossmatch_nested

3 participants