Skip to content

Conversation

@delucchi-cmu
Copy link
Contributor

Closes #716
Closes #664
Closes #673

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Before [9c72e6c] After [b57d8c2] Ratio Benchmark (Parameter)
13.0±0.3ms 13.2±0.2ms 1.01 benchmarks.time_box_filter_on_partition
6.41±0.01s 6.38±0.03s 1 benchmarks.time_create_large_catalog
81.2±0.7ms 80.8±0.8ms 1 benchmarks.time_kdtree_crossmatch
952±8ms 941±7ms 0.99 benchmarks.time_create_midsize_catalog
27.3±0.7ms 26.2±0.5ms 0.96 benchmarks.time_polygon_search

Click here to view all benchmarks.

@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (9c72e6c) to head (809a511).
⚠️ Report is 204 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #775   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files          54       54           
  Lines        2461     2461           
=======================================
  Hits         2398     2398           
  Misses         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@delucchi-cmu
Copy link
Contributor Author

@delucchi-cmu delucchi-cmu requested a review from gitosaurus May 19, 2025 18:10
Copy link
Contributor

@gitosaurus gitosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@delucchi-cmu delucchi-cmu merged commit 80ea0a6 into main May 20, 2025
12 of 13 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/716/id_search branch May 20, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants