Skip to content

Conversation

@olivialynn
Copy link
Member

I wrote section 2 in #616

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Before [e46d9aa] After [3ac5ede] Ratio Benchmark (Parameter)
12.8±0.1ms 13.1±0.2ms 1.02 benchmarks.time_box_filter_on_partition
923±7ms 941±6ms 1.02 benchmarks.time_create_midsize_catalog
6.26±0.03s 6.35±0.01s 1.01 benchmarks.time_create_large_catalog
80.0±0.2ms 81.2±0.4ms 1.01 benchmarks.time_kdtree_crossmatch
26.7±0.4ms 26.5±0.6ms 0.99 benchmarks.time_polygon_search

Click here to view all benchmarks.

@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.44%. Comparing base (e46d9aa) to head (2909543).
⚠️ Report is 195 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #781   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files          54       54           
  Lines        2461     2461           
=======================================
  Hits         2398     2398           
  Misses         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@olivialynn olivialynn requested a review from delucchi-cmu May 21, 2025 16:00
Copy link
Contributor

@delucchi-cmu delucchi-cmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmmm oxford comma mmmmmmmmmmmmmm

@olivialynn olivialynn merged commit 6718544 into main May 21, 2025
13 checks passed
@olivialynn olivialynn deleted the u/olynn/add-name branch May 21, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants