-
Notifications
You must be signed in to change notification settings - Fork 9
Join through association #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Click here to view all benchmarks. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
==========================================
+ Coverage 95.65% 96.85% +1.19%
==========================================
Files 54 54
Lines 2509 2540 +31
==========================================
+ Hits 2400 2460 +60
+ Misses 109 80 -29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Co-Authored-By: Sean McGuire <seanmcgu@andrew.cmu.edu>
The association tables may need to be repartitioned such that its pixels are different from the inner alignment between the primary and the join catalogs. If that's the case we need to recompute the alignment for the join.
This PR adds some logic to do that:
align_catalog_with_associationfirst aligns the primary catalog with the association catalog and then it aligns the result to the join catalog to obtain the pixels that need to be joined between the three.This is a step toward #795. However, I am looking for feedback since this solution will introduce new
assoc_Norderandassoc_Npixcolumns in the partition join info (apart from the already existing Norder, Npix and join_Norder, join_Npix).