Skip to content

Conversation

@delucchi-cmu
Copy link
Contributor

Closes #820

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Before [c5f85ab] After [05463e3] Ratio Benchmark (Parameter)
6.46±0.03s 6.53±0.04s 1.01 benchmarks.time_create_large_catalog
964±20ms 975±9ms 1.01 benchmarks.time_create_midsize_catalog
88.2±1ms 89.0±1ms 1.01 benchmarks.time_kdtree_crossmatch
14.7±0.4ms 14.5±0.5ms 0.99 benchmarks.time_box_filter_on_partition
30.5±0.5ms 29.2±0.7ms 0.96 benchmarks.time_polygon_search

Click here to view all benchmarks.

@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.46%. Comparing base (c5f85ab) to head (441769a).
⚠️ Report is 188 commits behind head on main.

Files with missing lines Patch % Lines
src/lsdb/io/to_hats.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   97.49%   97.46%   -0.04%     
==========================================
  Files          54       54              
  Lines        2475     2484       +9     
==========================================
+ Hits         2413     2421       +8     
- Misses         62       63       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@delucchi-cmu delucchi-cmu requested a review from camposandro June 11, 2025 16:21
Copy link
Collaborator

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@delucchi-cmu delucchi-cmu merged commit ba5aaa4 into main Jun 11, 2025
11 of 13 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/780/skymap branch June 11, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write skymap.fits on to_hats

3 participants