Skip to content

Conversation

@delucchi-cmu
Copy link
Contributor

Organizing existing catalogs into collections saves around 1M of space of duplicated unit test data.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Jun 16, 2025

Before [61f5aa9] After [9df2503] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.time_box_filter_on_partition
failed failed n/a benchmarks.time_polygon_search
6.39±0.03s 6.32±0.02s 0.99 benchmarks.time_create_large_catalog
83.5±0.9ms 82.9±2ms 0.99 benchmarks.time_kdtree_crossmatch
953±6ms 938±10ms 0.98 benchmarks.time_create_midsize_catalog

Click here to view all benchmarks.

@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.11%. Comparing base (61f5aa9) to head (ce1e966).
⚠️ Report is 183 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
- Coverage   97.47%   96.11%   -1.37%     
==========================================
  Files          54       54              
  Lines        2494     2494              
==========================================
- Hits         2431     2397      -34     
- Misses         63       97      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@delucchi-cmu delucchi-cmu requested a review from olivialynn June 17, 2025 13:55
@delucchi-cmu delucchi-cmu merged commit e18d49e into main Jun 24, 2025
12 of 13 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/collection branch June 24, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants