Skip to content

Conversation

@delucchi-cmu
Copy link
Contributor

Move all region _search methods from Catalog to HealpixDataset, as they are all possible for anything with spatial data.

Closes #523

Removes the skymap_data and skymap_histogram methods.

@delucchi-cmu delucchi-cmu requested a review from dougbrn July 25, 2025 15:42
@github-actions
Copy link

Before [a64e4f8] After [0578cdf] Ratio Benchmark (Parameter)
40.4±0.8ms 40.7±0.8ms 1.01 benchmarks.time_polygon_search
83.0±1ms 82.2±1ms 0.99 benchmarks.time_kdtree_crossmatch
6.47±0.03s 6.36±0.01s 0.98 benchmarks.time_create_large_catalog
967±10ms 952±5ms 0.98 benchmarks.time_create_midsize_catalog
25.8±0.2ms 24.3±0.3ms 0.94 benchmarks.time_box_filter_on_partition

Click here to view all benchmarks.

@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.14%. Comparing base (a64e4f8) to head (7bbe890).
⚠️ Report is 122 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #960      +/-   ##
==========================================
- Coverage   95.26%   95.14%   -0.13%     
==========================================
  Files          55       54       -1     
  Lines        2598     2531      -67     
==========================================
- Hits         2475     2408      -67     
  Misses        123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@delucchi-cmu delucchi-cmu merged commit e86459f into main Jul 25, 2025
11 of 13 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/523/search branch July 25, 2025 16:25
@delucchi-cmu delucchi-cmu mentioned this pull request Jul 26, 2025
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose pixel search to healpixdataset

3 participants