Skip to content

Conversation

@delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Aug 28, 2025

  • Breaks out the chunks within the API Reference > Catalog page into their own pages, as the left-hand navigation was getting cumbersome.
  • Adds a notebook based on this demo notebook
  • Adds notes on polygon search about requiring lsst-sphgeom. Closes Polygon search should mention additional required package #996
  • Fix to doc render errors in the dask-messages-guide. Unrelated, but I noticed errors while working on docs.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Aug 28, 2025

Before [0a02c58] After [db90ea4] Ratio Benchmark (Parameter)
41.1±0.5ms 41.7±0.4ms 1.01 benchmarks.time_polygon_search
25.0±0.1ms 25.1±0.2ms 1 benchmarks.time_box_filter_on_partition
5.78±0.02s 5.77±0.04s 1 benchmarks.time_create_large_catalog
93.3±1ms 93.1±2ms 1 benchmarks.time_kdtree_crossmatch
876±10ms 862±8ms 0.98 benchmarks.time_create_midsize_catalog

Click here to view all benchmarks.

@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.86%. Comparing base (0a02c58) to head (dd875be).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #998   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files          54       54           
  Lines        2554     2555    +1     
=======================================
+ Hits         2474     2475    +1     
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@olivialynn olivialynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The catalog subsections are a game changer; huge fan!

@delucchi-cmu delucchi-cmu merged commit f0694e6 into main Sep 2, 2025
12 of 13 checks passed
@delucchi-cmu delucchi-cmu deleted the issue/996/search_doc branch September 2, 2025 14:41
@delucchi-cmu delucchi-cmu mentioned this pull request Sep 19, 2025
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Polygon search should mention additional required package

3 participants