all: remove blank assignments for ignored calls (#356)

Author: astrophena

cmd/boot/internal/rescue/rescue.go

@@ -89,7 +89,7 @@ func (m *impl) update(thread *starlark.Thread, b *starlark.Builtin, args starlar
 				return "", err
 			}
 			if err := run(ctx, m.rt.NeedsSudo(), "", "sbctl", "sign", "-s", target); err != nil {
-				_ = run(ctx, m.rt.NeedsSudo(), "", "rm", "-f", target)
+				run(ctx, m.rt.NeedsSudo(), "", "rm", "-f", target)
 				return "", err
 			}
 			if err := prune(ctx, m.rt, esp, keep); err != nil {
@@ -164,7 +164,7 @@ func prune(ctx context.Context, rt *boot.Runtime, esp string, keep int) error {
 		if err := run(ctx, rt.NeedsSudo(), "", "rm", "-f", image.path); err != nil {
 			return err
 		}
-		_ = run(ctx, rt.NeedsSudo(), "", "sbctl", "remove-file", image.path)
+		run(ctx, rt.NeedsSudo(), "", "sbctl", "remove-file", image.path)
 	}
 	return nil
 }

cmd/tgfeed/internal/admin/admin.go

@@ -242,7 +242,7 @@ func (a *api) handleGetConfig(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 	w.Header().Set("Content-Type", "text/plain; charset=utf-8")
-	_, _ = w.Write([]byte(config))
+	w.Write([]byte(config))
 }
 
 func (a *api) handlePutConfig(w http.ResponseWriter, r *http.Request) {
@@ -280,7 +280,7 @@ func (a *api) handleGetState(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 	w.Header().Set("Content-Type", "application/json; charset=utf-8")
-	_, _ = w.Write(content)
+	w.Write(content)
 }
 
 func (a *api) handlePutState(w http.ResponseWriter, r *http.Request) {
@@ -313,7 +313,7 @@ func (a *api) handleGetErrorTemplate(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 	w.Header().Set("Content-Type", "text/plain; charset=utf-8")
-	_, _ = w.Write([]byte(errorTemplate))
+	w.Write([]byte(errorTemplate))
 }
 
 func (a *api) handlePutErrorTemplate(w http.ResponseWriter, r *http.Request) {

cmd/tgfeed/internal/state/state_test.go

@@ -53,7 +53,7 @@ func TestStoreRemoteErrorPropagation(t *testing.T) {
 	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		if r.URL.Path == "/api/config" {
 			w.WriteHeader(http.StatusBadRequest)
-			_, _ = w.Write([]byte(`{"error":"bad config"}`))
+			w.Write([]byte(`{"error":"bad config"}`))
 			return
 		}
 		w.WriteHeader(http.StatusNotFound)

internal/filelock/filelock.go

@@ -36,15 +36,15 @@ func Acquire(path string, payload string) (Lock, error) {
 	}
 	if payload != "" {
 		if err := lockFile.Truncate(0); err != nil {
-			_ = (&fileLock{file: lockFile}).Release()
+			(&fileLock{file: lockFile}).Release()
 			return nil, err
 		}
 		if _, err := lockFile.Seek(0, 0); err != nil {
-			_ = (&fileLock{file: lockFile}).Release()
+			(&fileLock{file: lockFile}).Release()
 			return nil, err
 		}
 		if _, err := lockFile.WriteString(payload); err != nil {
-			_ = (&fileLock{file: lockFile}).Release()
+			(&fileLock{file: lockFile}).Release()
 			return nil, err
 		}
 	}
@@ -61,7 +61,7 @@ func IsLocked(path string) bool {
 
 	err = syscall.Flock(int(lockFile.Fd()), syscall.LOCK_EX|syscall.LOCK_NB)
 	if err == nil {
-		_ = syscall.Flock(int(lockFile.Fd()), syscall.LOCK_UN)
+		syscall.Flock(int(lockFile.Fd()), syscall.LOCK_UN)
 		return false
 	}