-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numpy.linspace broken with Quantities #4543
Conversation
It is a numpy regression: see numpy/numpy#7142 |
@mhvk - is this now fixed post- numpy/numpy#7156 ? If so, how should we proceed on this issue - should we mention this as a "known issue" in numpy 1.10.x<1.10.5 ? (do you know how far back it goes?) |
@eteq - yes, it would be a known issue in numpy 1.10, up to 1.10.5. If anywhere, it would probably be part of http://docs.astropy.org/en/latest/known_issues.html#quantity-issues |
@eteq - I went ahead and made this into a PR with a small documentation update. Only thing I'm not quite sure about is whether I set the labels right... |
Quantities in np.linspace failure on numpy 1.10 | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
In numpy 1.10, `~numpy.linspace` initially failed to work with quantities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhvk - I would rephrase to say 'linspace does not work correctly with quantities when using Numpy 1.10.0 to 1.10.5 due to a bug in Numpy. The solution is to upgrade to Numpy 1.10.6, in which the bug was fixed'
a6773a3
to
4e45aad
Compare
@astrofrog - agreed, might as well be clear about where the problem was. Now changed the text. |
I'm going ahead and merge this small documentation update -- there's a bit of a cost to leaving things like this open, if only that they keep popping up any time I look at my open issues/PRs. |
numpy.linspace broken with Quantities with early numpy 1.10 -- documentation update
numpy.linspace broken with Quantities with early numpy 1.10 -- documentation update [ci skip]
numpy.linspace broken with Quantities with early numpy 1.10 -- documentation update [ci skip]
Numpy's linspace used to work nicely with quantities:
Numpy 1.9.3
Numpy 1.10
@mhvk - is this a bug in Astropy, or a bug introduced in Numpy?
A lot of user code might rely on this, so we should get a workaround out soon unless it has to be fixed in Numpy.